On Wed, May 16, 2012 at 7:33 PM, Wanlong Gao <[email protected]> wrote: > On 05/17/2012 10:31 AM, Garrett Cooper wrote: > >> On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao <[email protected]> >> wrote: >>> On 05/17/2012 09:59 AM, Peng Haitao wrote: >>> >>>> When execvp() fails, the testcases is counted in Total Tests, but not >>>> added in logfile. In fact the testcases result should be added in logfile. >>> >>> I prefer adding this for matching the Total Tests amount. >>> So, >>> >>> Acked-by: Wanlong Gao <[email protected]> >> >> It's nice that this is finally being fixed. This is one issue that >> has been outstanding for several years that needed to be resolved (I >> noticed it during/after I developed the execltp python script). > > > So, Garrett, you can ACK this?
I will ACK the sentiment, but I prefer to test it in order to ensure that it actually works... You can easily trigger this problem with the following spoofed runtest scenario: aok echo "hello" donotexist donotexist exit_quickly exit 1 true true The first will fail success with "hello" output, the second should fail with ENOENT, the third will fail without output, and the fourth should success with output. If this functions as I described above, I'll be more than happy to ACK the patch. Thanks! -Garrett ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
