Hi! > >>> move_pages_support: use only allowed nodes > >>> move_pages: dont use hardcoded node numbers > >>> > >>> .../kernel/syscalls/move_pages/move_pages02.c | 13 +++- > >>> .../kernel/syscalls/move_pages/move_pages03.c | 13 +++- > >>> .../kernel/syscalls/move_pages/move_pages04.c | 13 +++- > >>> .../kernel/syscalls/move_pages/move_pages05.c | 13 +++- > >>> .../kernel/syscalls/move_pages/move_pages06.c | 10 ++- > >>> .../kernel/syscalls/move_pages/move_pages07.c | 13 +++- > >>> .../kernel/syscalls/move_pages/move_pages08.c | 12 +++- > >>> .../kernel/syscalls/move_pages/move_pages09.c | 8 ++- > >>> .../kernel/syscalls/move_pages/move_pages10.c | 13 +++- > >>> .../kernel/syscalls/move_pages/move_pages11.c | 13 +++- > >>> .../syscalls/move_pages/move_pages_support.c | 74 > >>> ++++++++++++++++---- > >>> .../syscalls/move_pages/move_pages_support.h | 1 + > >>> 12 files changed, 157 insertions(+), 39 deletions(-) > >>> > >> > >> Looks like many duplications here... wondering if any chance putting > >> them into a common function or something? > >> > > > > That is probably good idea, because we may still find new places where can > > use it. > > I'm thinking about something like numa_helper.a, which we could link with > > I have no objection doing that. > > Cyril, suggestions?
Yes, that is always a good idea. The easiest thing to do is to create a common.c file and include it in each of the tests (which I would do if the amount of shared code is relatively small and is used only by the tests in current directory). Otherwise you may do the usual library thing with actual headers and link tests against it... -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
