----- Original Message -----
> From: "Garrett Cooper" <[email protected]>
> To: "Jan Stancek" <[email protected]>
> Cc: [email protected], "Jeffrey Burke" <[email protected]>
> Sent: Monday, 28 May, 2012 8:28:39 PM
> Subject: Re: [LTP] [PATCH 2/4] mbind01: dont use hardcoded NUMA node ids
> 
> On Mon, May 28, 2012 at 4:39 AM, Jan Stancek <[email protected]>
> wrote:
> >
> > Signed-off-by: Jan Stancek <[email protected]>
> > ---
> >  testcases/kernel/syscalls/mbind/Makefile  |    3 +--
> >  testcases/kernel/syscalls/mbind/mbind01.c |   10 ++++++++--
> >  2 files changed, 9 insertions(+), 4 deletions(-)
> 
> +     if ((ret = get_allowed_nodes(1, &test_node)) < 0) {
> +             tst_brkm(TBROK|TERRNO, cleanup, "get_allowed_nodes(): %d", ret);
> +     }
> 
>     Is this always guaranteed to set errno to a sane value?

Thanks for your reviews Garrett.

For -1 and -2, malloc() and syscall() should take care of that.
But -3 seems loose at the moment, I can add there:
    errno = EINVAL;

Regards,
Jan

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to