Hi,

On Fri, Jun 15, 2012 at 5:37 PM, <[email protected]> wrote:

> Hi!
> > Here we can see that the script couldn't find the files.tar.gz file and
> > exited. The problem I noticed in the script was, when the script executes
> > the gzip command on the files.tar, the files.tar.gz file is created in
> the
> > $PWD and hence it has to be moved to the $LTPTMP directory. After doing
> > this change the output of the script was mentioned below:
>
> Maybe it would be better to create the file directly in LTPTMP.
>

Yes that sounds much better and we can remove the overhead of the move
operation :)


>
> And regarding the patch. Please send one with signed-of-by, line (git
> can create these for you). And change the comment a little. Usuall
> format is:
>
> First line with short description
> (empty line)
> Longer description composing possibly of several lines.
>

I had updated the patch with the signoff and the instructions mentioned as
above. Hope this patch now looks better.


Thanks,
Sujith H

-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info

Attachment: 0001-Fixing-the-gzip-issue-in-the-Test-8.patch
Description: Binary data

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to