Hi!
> diff --git a/testcases/kernel/syscalls/ipc/shmat/Makefile
> b/testcases/kernel/syscalls/ipc/shmat/Makefile
> index f467389..5cbf37c 100644
> --- a/testcases/kernel/syscalls/ipc/shmat/Makefile
> +++ b/testcases/kernel/syscalls/ipc/shmat/Makefile
> @@ -20,4 +20,7 @@ top_srcdir ?= ../../../../..
>
> include $(top_srcdir)/include/mk/testcases.mk
> include $(abs_srcdir)/../Makefile.inc
> +
> +MAKE_TARGETS := $(patsubst $(abs_srcdir)/%.c,%,$(wildcard
> $(abs_srcdir)/*[0-9].c))
Hm, perhaps it would be easier to rename the shmat_common.c to
shmat_common.h.
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
> diff --git a/testcases/kernel/syscalls/ipc/shmat/shmat01.c
> b/testcases/kernel/syscalls/ipc/shmat/shmat01.c
> index 6e4dee1..1f46b23 100644
> --- a/testcases/kernel/syscalls/ipc/shmat/shmat01.c
> +++ b/testcases/kernel/syscalls/ipc/shmat/shmat01.c
> @@ -56,6 +56,7 @@
> */
>
> #include "ipcshm.h"
> +#include "shmat_common.c"
>
> char *TCID = "shmat01";
>
> @@ -108,6 +109,7 @@ int main(int ac, char **av)
> /*
> * Use TEST macro to make the call
> */
Once you are touching the source, you are welcomed to remove
dumbious comments like this (ideally in separate patch). ;)
> diff --git a/testcases/kernel/syscalls/ipc/shmat/shmat_common.c
> b/testcases/kernel/syscalls/ipc/shmat/shmat_common.c
> new file mode 100644
> index 0000000..5a920c8
> --- /dev/null
> +++ b/testcases/kernel/syscalls/ipc/shmat/shmat_common.c
> @@ -0,0 +1,33 @@
> +static key_t probe_key;
> +
> +void *probe_free_addr()
Add void as the function parameters here.
> +{
> + void *p;
> + int ret;
> + int shm_id = -1;
> +
> + if (probe_key == 0)
> + probe_key = getipckey();
> +
> + /* create a shared memory resource with read and write permissions
> + * We align this to SHMLBA so we should allocate at least
> + * SHMLBA*2 in case SHMLBA > page_size. */
> + shm_id = shmget(probe_key, SHMLBA*2, SHM_RW | IPC_CREAT | IPC_EXCL);
> + if (shm_id == -1)
> + tst_brkm(TBROK, cleanup, "probe: shmget failed");
> +
> + /* Probe an available linear address for attachment */
> + p = shmat(shm_id, NULL, 0);
> + if (p == (void *)-1)
> + tst_brkm(TBROK, cleanup, "probe: shmat failed");
> + ret = shmdt((const void *)p);
Hmm, is this cast really needed?
> + if (ret == -1)
> + tst_brkm(TBROK, cleanup, "probe: shmdt failed");
> +
> + rm_shm(shm_id);
> +
> + /* some architectures (e.g. parisc) are strange, so better always
> + * align to next SHMLBA address. */
> + p = (void *)(((unsigned long)(p) + (SHMLBA - 1)) & ~(SHMLBA - 1));
> + return p;
> +}
--
Cyril Hrubis
[email protected]
------------------------------------------------------------------------------
The Windows 8 Center - In partnership with Sourceforge
Your idea - your app - 30 days.
Get started!
http://windows8center.sourceforge.net/
what-html-developers-need-to-know-about-coding-windows-8-metro-style-apps/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
