On 12/04/2012 03:21 PM, Peng Haitao wrote:
> + 84» .·cmdlib.sh

Patch series looks good to me except this.

sourcing a lib inside a function seems not so good. Yet I don't see any 
code style rules telling which is the correct place to put a shell lib 
source (commonly I think it would be the top in the file)

Thanks,
Caspar

> + 85» restart_daemon·atd




------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to