----- Original Message -----
> From: [email protected]
> To: "Jan Stancek" <[email protected]>
> Cc: [email protected]
> Sent: Tuesday, 12 February, 2013 2:09:26 PM
> Subject: Re: [LTP] [PATCH v2 3/3] setns: add new syscall test setns02
> 
> Hi!
> > > > +static void setup(void)
> > > > +{
> > > > +       char tmp[PATH_MAX];
> > > > +
> > > > +       tst_require_root(NULL);
> > > > +
> > > > +       /* runtime check if syscall is supported */
> > > > +       syscall(__NR_setns, -1, 0);
> > > > +
> > > 
> > > What happens when the syscall is not supported? The call should
> > > return
> > > -1 and errno should be set to ENOSYS but the return value is not
> > > checked, I'm puzzled.
> > 
> > It's a bit unfortunate name collision with syscall macro defined
> > in linux_syscall_numbers.h. That macro contains check for ENOSYS.
> 
> Ah, now I remeber.
> 
> We really should change that one. Any volunteers?

Sure :-), would "ltp_syscall" as name of that macro work for everyone?

Regards,
Jan

------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to