On Thursday 14 March 2013 12:31:24 [email protected] wrote: > > Signed-off-by: Markos Chandras <[email protected]> > > > > --- a/testcases/kernel/include/linux_syscall_numbers.h > > +++ b/testcases/kernel/include/linux_syscall_numbers.h > > @@ -16,6 +16,7 @@ > > #include <errno.h> > > #include <sys/syscall.h> > > #include "cleanup.c" > > +#include "test.h" > > > > #define ltp_syscall(NR, ...) ({ \ > > > > int __ret; \ > > Hmm, this header gets included after the test.h in the testcases so this > shouldn't be needed but I don't have strong opinion whether it's better > with or without it. > > Anybody has idea?
in general, you should include headers you use. however, are there any valid cases where people want to use this header but not test.h ? or is the file including this header also missing a test.h include ? if the latter, i say fix that and leave it out of this one (as a poor man's check). -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
