Hi,
In the current version of LTP(ltp-full-20130109), I have seen couple of SCTP
Functional tests failures.
1)test_assoc_abort.c
2)test_1_to_1_sockopt.c
After adding following patches, both the func_tests passes
1)For test_assoc_abort
The SCTP_COMM_LOST notification that was a result of an abort
now contains the additional parameter that includes the error
from the abort chunk. Need to account for that when checking
the received notification.
--- a/src/func_tests/test_assoc_abort.c
+++ b/src/func_tests/test_assoc_abort.c
@@ -231,7 +231,7 @@ main(int argc, char *argv[])
inmessage.msg_controllen = sizeof(incmsg);
error = test_recvmsg(clt_sk[i], &inmessage, MSG_WAITALL);
test_check_msg_notification(&inmessage, error,
- sizeof(struct sctp_assoc_change),
+ sizeof(struct sctp_assoc_change)+4,
SCTP_ASSOC_CHANGE, SCTP_COMM_LOST);
2)For test_1_to_1_sockopt
test_1_to_1_sockopt: fix deprecated SO_RCVBUF/SO_SNDBUF testcase
Actually, it is not guaranteed, that the rcv/snd buffer size, we send
is really set by the kernel. For small values, the SOCK_MIN_SNDBUF and
SOCK_MIN_RCVBUF sizes in include/net/sock.h are used instead. This was
the sole reason why this test, whose implementation was in 2005, failed.
Just change it to something bigger is not critical, and we're good to go.
--- a/src/func_tests/test_1_to_1_sockopt.c
+++ b/src/func_tests/test_1_to_1_sockopt.c
@@ -301,7 +301,7 @@ main(void)
/* Reducing the SO_RCVBUF value using setsockopt() */
/*Minimum value is 128 and hence I am using it*/
len = sizeof(int);
- rcvbuf_val_set = 128;
+ rcvbuf_val_set = 2048;
/* TEST16: Test case for setsockopt SO_RCVBUF */
error = setsockopt(sk2, SOL_SOCKET, SO_RCVBUF, &rcvbuf_val_set, len);
if (error < 0)@@ -320,7 +320,7 @@ main(void)
"got value differs Set Value=%d Get Value=%d",
(2*rcvbuf_val_set), rcvbuf_val_get);
- sndbuf_val_set=1024;
+ sndbuf_val_set = 2048;
/* TEST17: Test case for setsockopt SO_SNDBUF */
error = setsockopt(sk2, SOL_SOCKET, SO_SNDBUF, &sndbuf_val_set, len);
if (error < 0)
It would be nice if the upcoming LTP release could pick up the updated versions
of the lksctp-tools-1.0.13 tests.
Thanks,
Nagaraj Arankal
________________________________
Information transmitted by this e-mail is proprietary to MphasiS, its
associated companies and/ or its customers and is intended for use only by the
individual or entity to which it is addressed, and may contain information that
is privileged, confidential or exempt from disclosure under applicable law. If
you are not the intended recipient or it appears that this mail has been
forwarded to you without proper authority, you are notified that any use or
dissemination of this information in any manner is strictly prohibited. In such
cases, please notify us immediately at [email protected] and delete this
mail from your records.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
