Hi!
> ?????????????? /* Control parameters for ECHO replies. */??????????????
> net->ipv4.sysctl_icmp_echo_ignore_all = 0;??????????????
> net->ipv4.sysctl_icmp_echo_ignore_broadcasts = 1;??In ???mc_cmds??? test case
> we have code as below:???? ??cat
> /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts | grep 1 > /dev/null???? if [
> $? -eq 0 ]???? then???????????? end_testcase "Multicast ping disabled on this
> system (this is normal on post year:2005 kernels)"???? fiHence the test tcase
> will fail always as icmp_echo_ignore_broadcasts is set to 1(which is
> default).??Can we go with below patch for this problem???---
> mc_cmds.Orig?????????????? 2013-04-03 14:36:14.000000000 -0600+++
> mc_cmds???????? 2013-04-03 14:39:02.000000000 -0600@@ -128,6 +128,9 @@??????
> if [ $? -eq 0 ]?????? then?????????????? end_testcase "Multicast ping
> disabled on this system (this is normal on post year:2005
> kernels)"+???????????? echo "Temporarily enable multicast ping for testing
> purposes."+???????????? echo 0 >
> /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts+????????????
> icmp_need_reset=1?????? fi???????? # Do the ping tests: Execute ping
> 224.0.0.1 - Verify that the proper@@ -166,6 +169,10 @@ {??????
> $trace_logic?????? echo "$this_file: doing $0."+???? if [ -n
> "$icmp_need_reset" ]; then+???????????? echo 1 >
> /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts+???????????? echo "Restored
> multicast ping setting."+???? fi?????? rm -rf $PING_OUT }??
Looks like the email was mangled, most likely by your mail client.
> --- mc_cmds.Orig 2013-04-03 14:36:14.000000000 -0600
> +++ mc_cmds 2013-04-03 14:39:02.000000000 -0600
> @@ -128,6 +128,9 @@
> if [ $? -eq 0 ]
> then
> end_testcase "Multicast ping disabled on this system (this is normal
> on post year:2005 kernels)"
> + echo "Temporarily enable multicast ping for testing purposes."
> + echo 0 > /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts
> + icmp_need_reset=1
> fi
>
> # Do the ping tests: Execute ping 224.0.0.1 - Verify that the proper
> @@ -166,6 +169,10 @@
> {
> $trace_logic
> echo "$this_file: doing $0."
> + if [ -n "$icmp_need_reset" ]; then
> + echo 1 > /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts
> + echo "Restored multicast ping setting."
> + fi
> rm -rf $PING_OUT
> }
Could you send these as signed patches in unified diff format with the
description of the changes in the patch header?
(git can help you create these)
--
Cyril Hrubis
[email protected]
------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire
the most talented Cisco Certified professionals. Visit the
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
