On Tuesday 23 April 2013 12:46:42 [email protected] wrote:
> > is keeping it in the tree a big deal ?  i think it's pretty common for
> > people to go into specific subdirs and run `make` and today, our
> > subdirs don't declare a dependency on this file so it'll get
> > automatically regenerated (nor do i think they should even bother).
> 
> You need to regenerate the file after each change to the *.in files,
> and that means that people will forget from time to time.

so people aren't testing their commits ;)

> It would be better to add another rule to testcases.mk similiar to the
> one for LIBLTP.

those rules only generate libltp.a if the file doesn't already exist.  so 
tweaking that would be like the status quo, but worse in that `git pull` is 
now guaranteed to not update the file :).

i don't want to add things like `make -C testcases/kernel/include/` as then 
you'll have multiple subdirs processing the same thing.  maybe if we had a .mk 
file in testcases/kernel/include/ that testcases.mk could include, and if the 
top level testcases/kernel/ make sure we process that first before any subdirs.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to