On 04/24/2013 05:36 PM, [email protected] wrote:
> Hi!
>>>     for (lc = 0; TEST_LOOPING(lc); lc++) {
>>> -           /* reset tst_count in case we are looping */
>>>             tst_count = 0;
>>>
>>>             /* allocate space for the itimerval structure */
>>> -
>>> -           if ((value = (struct itimerval *)malloc((size_t)
>>> -                                                   sizeof(struct
>>> -                                                          itimerval))) ==
>>> -               NULL) {
>>> +           value = (struct itimerval *)malloc(
>>> +                                   (size_t)sizeof(struct itimerval));
>>
>> The type cast here is not necessary, right?
> 
> The itimerval structure is about 32 bytes long. I would just declare it 
> on the stack and pass &value to the call.

Agreed.

Thanks,
Wanlong Gao

> 


------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to