On Saturday 27 April 2013 00:23:14 Zhouping Liu wrote: > The reason is that node0 only contains all CPUs, no any memory,
no any memory -> no memory
> and node1 contains all memory, but no CPUs, in the previous codes,
change "CPUs, in" to "CPUs. In"
> we only do cpuset testing on a independent node, which caused the
a -> an
> sub-cpuset cgroup only contains CPUs or memory in one node, but
only contains -> to only contain
> that's not permitted in the special machine. The patch fixed it.
what is a "special machine" ?
also, generally there's no need to say "The patch fixed it". the fact that
you've described a bug and have a patch implies that this fixes things.
> + tst_resm(TINFO, "None CPUs in the node%ld", nd);
i think you mean "no" instead of "None"
> + tst_resm(TINFO, "Only use CPU0 in the cpuset cgroup "
> + "for the special scenario");
what is "the special scenario" ?
> mount_mem("cpuset", "cpuset", NULL, CPATH, CPATH_NEW);
> - if (is_numa(cleanup) > 0)
> - /* For NUMA system, using the first node for cpuset.mems */
> - write_cpusets(get_a_numa_node(cleanup));
> - else
> - /* For nonNUMA system, using node0 for cpuset.mems */
> - write_cpusets(0);
> +
> + /*
> + * Not any nodes contain memory, so using get_allowed_nodes(NH_MEMS)
"Not any" -> "No"
"using" -> "use"
> + * to get a memory node, the operation also applies to Non-NUMA
change the ", the" to ". This".
> + * system.
systems.
> + /*
looks like you mixed spaces & tabs. only use tabs.
> + * Not any nodes contain memory, so using get_allowed_nodes(NH_MEMS)
> + * to get a memory node, the operation also applies to Non-NUMA
> + * system.
same comments about the grammar here as above
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
