On 04/17/2013 03:37 PM, Jan Stancek wrote: > > > > > ----- Original Message ----- >> From: "Lans Zhang"<[email protected]> >> To: "Zhouping Liu"<[email protected]>, "Jan Stancek"<[email protected]> >> Cc: "Wanlong Gao"<[email protected]>, [email protected] >> Sent: Wednesday, 17 April, 2013 7:09:00 AM >> Subject: [LTP][PATCH V2] Fix short of nodemask array. >> >> Changes since V1: >> 1. Enhance patch header. >> 2. Use BITS_PER_LONG and set_node() to simplify the logic. >> >> In kernel, if user specified more nodes, e.g, 512 nodes, than the >> supported, e.g, 4 nodes, kernel will check if the non supported >> part, e.g, 508 nodes, is all zeroed in node bitmap. Currently, we >> are overrunning "nmask", whose length is shorter than MAXNODES, >> and where the unsupported bits should be cleared to pass the check. >> >> Signed-off-by: Lans Zhang<[email protected]> > > Hi, > > 'v' should be probably dropped here, since it's not used and rest > of patch uses 2 parameters anyway: > >> +static inline void set_node(unsigned long *array, unsigned int node, >> + unsigned int v) >> +{ >> + array[node / BITS_PER_LONG] |= 1UL<< (node % BITS_PER_LONG); >> +} >> > > Other than that, it looks good to me.
I will send a V3 if Zhouping Liu also gatekeep V2 except this minor change. Thanks, lz > > Regards, > Jan > ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
