On Monday 06 May 2013 05:41:18 Alexey Kodanev wrote: > +#define BASE_DIR_NUM (USERS_NUM+1)
spaces around that +
> +#define MAX_ENTITIES (MAX_FILES_CREATED*BASE_DIR_NUM)
spaces around that *
> +static const char *file_postfix = ".hs";
for const strings you don't modify the pointer, use []:
static const char file_postfix[] = ".hs";
> +option_t options[] = {
static, and probably const
> +static int cwd_offset;
you assign the return value of strlen() to this, so it should be size_t
> +static const char *hrdlink_proc_path =
> +static const char *symlink_proc_path =
same thing wrt to * vs []
> +static void setup(int ac, char **av);
please use instead for argv:
char *argv[]
> +int main(int ac, char **av)
same here
> + if (tst_kvercmp(3, 7, 0) < 0) {
> + tst_brkm(TCONF, &cleanup,
> + "Test must be run with kernel 3.7 or newer");
unwrap, or indent the string one more level
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
