On Thursday 09 May 2013 22:35:15 DAN LI wrote: > On 05/10/2013 12:22 AM, Mike Frysinger wrote: > > On Thursday 09 May 2013 04:42:55 DAN LI wrote: > >> --- a/testcases/kernel/syscalls/ipc/semctl/semctl01.c > >> +++ b/testcases/kernel/syscalls/ipc/semctl/semctl01.c > >> > >> /* > >> > >> @@ -24,32 +23,6 @@ > >> > >> * DESCRIPTION > >> * semctl01 - test the 10 possible semctl() commands > >> * > >> > >> - * ALGORITHM > >> - * create a semaphore set with read and alter permissions > >> - * loop if that option was specified > >> - * loop through the test cases > >> - * do any setup required for the test case > >> - * make the semctl() call using the TEST() macro > >> - * check the return code > >> - * if failure, issue a FAIL message. > >> - * otherwise, > >> - * if doing functionality testing > >> - * call the appropriate test function > >> - * if correct, > >> - * issue a PASS message > >> - * otherwise > >> - * issue a FAIL message > >> - * call cleanup > > > > i don't see high level DESCRIPTION/ALGORITHM as "useless". why do you ? > > In my opinion, "ALGORITHM" section of many ltp testcases follows one > format: ------------------------------------------------ > setup() > loop test frame > loop all test cases > TEST(call) > if call failed > log the errno > else > if functionality is ok > case PASS > else > case FAIL > cleanup() > ------------------------------------------------ > > So, i think this section is redundant and useless once someone has > learned the test frame.
and if you delete all the sections, then what are people going to refer to ? -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
