Hi, sirs any comment for this patch?
This unnecessary calling of cleanup() will cause TC prot_hsymlinks failing when kernel is older than 3.7.0. On 05/16/2013 02:08 PM, DAN LI wrote: > > Should not call cleanup here since nothing was setted by setup. > > Signed-off-by: DAN LI <[email protected]> > --- > testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c > b/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c > index 1eec0f9..82bc770 100644 > --- a/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c > +++ b/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c > @@ -196,10 +196,9 @@ static void setup(int argc, char *argv[]) > > tst_require_root(NULL); > > - if (tst_kvercmp(3, 7, 0) < 0) { > - tst_brkm(TCONF, cleanup, > + if (tst_kvercmp(3, 7, 0) < 0) > + tst_brkm(TCONF, NULL, > "Test must be run with kernel 3.7 or newer"); > - } > > /* initialize user names */ > strcpy(users[ROOT].name, "root"); > ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
