Hi, > > > > This patch tries to build kernel module also on kernels < 3.7, which seems > > unnecessary, because the test won't run. And for very old kernels it won't > > build at all. > > > > I know some people still build/run LTP on kernels as old as 2.6.18, which > > is why > > I would rather go with WITH_MODULES="no" as default, if more kernel modules > > become part of the build. > > Right, we should at least limit the module build to kernel versions that > are known to work. In this particular case I would limit it to 3.7+
Or even better to be both forward and backward compatible, we should not stop the build when kernel module has failed to build. We should carry on with the build, install etc. and return TCONF when the particula test was called. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
