+list On 07/05/2013 10:20 AM, Hangbin Liu wrote: > I didn't run xinetd before, but It do have this issue. when we call > getaddrinfo(3) to get host name's IP address. It will return multiple > answers, and prefer v6 to v4. So this patch make sence. But I > recommend we can add IPv6 test for xinetd, not just disable it. > > 2013/7/4 Caspar Zhang <[email protected]>: >> Hangbin, have you executed such tests before, and/or met any ipv4/v6 issue? >> >> Thanks, >> Caspar >> >> >> >> On 07/04/2013 09:30 PM, Xie Lingyun wrote: >>> >>> If IPV6 is enabled, telnet localhost becomes telnet ::1 and telnet >>> 127.0.0.1. >>> The first one makes the command output different from the expected result. >>> >>> >>> Thanks, >>> Lingyun Xie >>> >>> 0001-xinetd-xinetd_tests.sh-disable-the-IPV6-localhost.patch >>> >>> >>> From 75c79721c095cce27548e74260c1e42681e1a267 Mon Sep 17 00:00:00 2001 >>> From: mellonwand<[email protected]> >>> Date: Thu, 4 Jul 2013 16:42:42 +0800 >>> Subject: [PATCH] xinetd/xinetd_tests.sh:disable the IPV6 localhost >>> >>> If IPV6 is enabled, telnet localhost becomes telnet ::1 and telnet >>> 127.0.0.1. The first one makes the command's output different from the >>> expected output. >>> >>> Signed-off-by: Xie Lingyun<[email protected]> >>> --- >>> testcases/network/xinetd/xinetd_tests.sh | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/testcases/network/xinetd/xinetd_tests.sh >>> b/testcases/network/xinetd/xinetd_tests.sh >>> index 83eb8a7..d2c851d 100755 >>> --- a/testcases/network/xinetd/xinetd_tests.sh >>> +++ b/testcases/network/xinetd/xinetd_tests.sh >>> @@ -128,6 +128,7 @@ init() >>> >>> # Create expected file with telnet disabled. >>> cat > $LTPTMP/tst_xinetd.exp.1 <<-EOF || RC=$? >>> + telnet: connect to address 127.0.0.1: Connection refused >>> telnet: Unable to connect to remote host: Connection refused >>> EOF >>> >>> @@ -263,7 +264,7 @@ test01() >>> >>> # Not checking for exit code from telnet command because telnet is >>> # not terminated by the test gracefully. >>> - echo " " | telnet localhost 2>$LTPTMP/tst_xinetd.out 1>/dev/null >>> + echo " " | telnet 127.0.0.1 2>$LTPTMP/tst_xinetd.out 1>/dev/null >>> diff -iwB $LTPTMP/tst_xinetd.out $LTPTMP/tst_xinetd.exp.1 \ >>> > $LTPTMP/tst_xinetd.err 2>&1 || RC=$? >>> if [ $RC -ne 0 ] >>> @@ -312,7 +313,7 @@ test01() >>> >>> # Not checking for exit code from telnet command because telnet is >>> # not terminated by the test gracefully. >>> - echo " " | telnet localhost > $LTPTMP/tst_xinetd.out 2>&1 >>> + echo " " | telnet 127.0.0.1 > $LTPTMP/tst_xinetd.out 2>&1 >>> >>> diff -iwB $LTPTMP/tst_xinetd.out $LTPTMP/tst_xinetd.exp.2 \ >>> > $LTPTMP/tst_xinetd.err 2>&1 || RC=$? >>> -- 1.8.3.1 >>> >>
------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
