On 07/11/2013 11:35 AM, Hangbin Liu wrote:
> On Thu, Jul 11, 2013 at 01:28:34AM +0800, Caspar Zhang wrote:
>> On 07/10/2013 07:03 PM, Xie Lingyun wrote:
>>> +defaults
>>> +{
>>> +instances      = 25
>>> +log_type       = FILE /var/log/servicelog
>>> +log_on_success = HOST PID
>>> +log_on_failure = HOST RECORD
>>> +disabled       = telnet
>>> +}
>>
>> Generally looks good except here.
>>
>> better give a 4-space indentation inside the braces.
>>
> 
> 1-tab or 4-space, I always be confuse which should we use. Even a tab should
> be 4 characters or 8 characters also have dispute. But the kernel coding style
> said Tabs are 8 characters, and thus indentations are also 8 characters.
> 
> So, should we also use this style in shell scripts? Because I'm tired
> changing my vim config for each project.

We are just following kernel coding style in LTP.

Thanks,
Wanlong Gao

> 


------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to