Hi! > >> The definitions of MS_PRIVATE and MS_MOVE were only added to glibc headers > >> in version 2.12. > >> > >> If the version of glibc is older than 2.12, define these two flags. > >> > >> Signed-off-by: DAN LI <[email protected]> > >> --- > >> testcases/kernel/syscalls/mount/mount06.c | 5 +++++ > >> 1 files changed, 5 insertions(+), 0 deletions(-) > >> > >> diff --git a/testcases/kernel/syscalls/mount/mount06.c > >> b/testcases/kernel/syscalls/mount/mount06.c > >> index acfb22d..ab1a472 100644 > >> --- a/testcases/kernel/syscalls/mount/mount06.c > >> +++ b/testcases/kernel/syscalls/mount/mount06.c > >> @@ -31,6 +31,11 @@ > >> #include "usctest.h" > >> #include "safe_macros.h" > >> > >> +#if !(__GLIBC_PREREQ(2, 12)) > > > > Why not do like below? > > I think it also clearly shows the reason why this definition should > exist here(glibc version related).
Well the same is told in the git commit log anyway. (Which is the place where people should look for verbose description of changes.) And this kind of code may break with different libc implementation where there is no __GLIBC_PREREQ() macro. So I vote for the: #ifndef FOO # define FOO xyz #endif -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
