----- Original Message -----
> From: "Wanlong Gao" <[email protected]>
> To: "Jan Stancek" <[email protected]>
> Cc: [email protected], "LTP" <[email protected]>
> Sent: Wednesday, 7 August, 2013 10:23:27 AM
> Subject: Re: [LTP] [PATCH] sigaction:16-1: leave it untested on the Linux 
> kernel less than 2.6.22
> 
> On 08/06/2013 04:11 PM, Jan Stancek wrote:
> > 
> > 
> > 
> > 
> > ----- Original Message -----
> >> From: [email protected]
> >> To: "Wanlong Gao" <[email protected]>
> >> Cc: "LTP" <[email protected]>
> >> Sent: Monday, 5 August, 2013 11:46:48 AM
> >> Subject: Re: [LTP] [PATCH] sigaction:16-1: leave it untested on the Linux
> >> kernel less than 2.6.22
> >>
> >> Hi!
> >>> As the Linux signal(7) said:
> >>> POSIX semaphore interfaces: sem_wait(3) and sem_timedwait(3) (since Linux
> >>> 2.6.22; beforehand, always failed with EINTR).
> >>>
> >>> So, on linux, we just leave this untested when the kernel version
> >>> is less than 2.6.22.
> >>
> >> While I'm completly fine with workarounds for broken kernels in Linux
> >> part of the LTP I'm a bit reluctant to add them into the open posix
> >> testsuite. Has anybody different opinion?
> > 
> > I agree when it comes to modifying testcases, but having a list
> > of testcases which are known to fail (and avoid running them)
> > on linux is also handy.
> > 
> > How about something like top-level Makefile.linux, which would
> > build everything as it does now, but after that it disables
> > those which are known to fail? For example by replacing something.run-test
> > with script that prints message and returns UNTESTED.
> 
> Do you have time to cook a patch as your suggestion?

Not very likely this week, since other tasks have more priority.
Anyway to continue discussion or as starting point here's what
I had in mind:

# cat Makefile.linux 
include Makefile

all: conformance-all functional-all stress-all tools-all filter-broken

cmd_disable = @set -e; \
        echo "Disabling: $(1)"; \
        echo "\#!/bin/sh" > $(1); \
        echo "echo $(1) skipped" >> $(1); \
        echo "echo $(2)" >> $(1); \
        echo "exit 0" >> $(1); \
        chmod a+x $(1)

filter-broken: t_sigaction_16-1

t_sigaction_16-1:
        $(call 
cmd_disable,conformance/interfaces/sigaction/sigaction_16-1.run-test,\
                This fails on linux because...)

# make -f Makefile.linux all
...
# ./conformance/interfaces/sigaction/sigaction_16-1.run-test
conformance/interfaces/sigaction/sigaction_16-1.run-test skipped
This fails on linux because...

Kernel version check shouldn't be hard to do. Do we also have some 
which depend on glibc version?

Regards,
Jan

> 
> Thanks,
> Wanlong Gao
> 
> > 
> > Regards,
> > Jan
> > 
> >>
> >> --
> >> Cyril Hrubis
> >> [email protected]
> >>
> >> ------------------------------------------------------------------------------
> >> Get your SQL database under version control now!
> >> Version control is standard for application code, but databases havent
> >> caught up. So what steps can you take to put your SQL databases under
> >> version control? Why should you start doing it? Read more to find out.
> >> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> >> _______________________________________________
> >> Ltp-list mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/ltp-list
> >>
> > 
> 
> 

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to