On 08/22/2013 05:22 PM, [email protected] wrote: > Hi! >>> I've just pushed a patchset that implements this functionality. >>> (It has been finished previous week but I hold it util I had time to >>> test it properly) >>> >>> Everybody please test this change and report any problems. >> >> I got a little problem when using this function. >> >> >> Defaultly, the command mkfs.xfs will not write to the device if it suspects >> that >> there is a filesystem or partition table on the device already. >> So, i need to add the "-f" option for mkfs.xfs to force the formatting. >> >> But, the command "mkfs dev -t xfs -f" does not work as expected. >> Could you please change it to "mkfs -t fs_type fs_opts dev" in tst_mkfs()? > > I've created and pushed a patch that shuffles the params so that they > are in right order. > > And I'm thinking if it actually would be better to add the -f parameter > in the tst_mkfs() if fs_type is xfs. As just now if you want to run any > of the tests that operate on a filesystem with xfs it fails in the same > way. >
Agree. But, someone who knows "-f" as a do's for mkfs.xfs maybe still calls tst_mkfs() with the "-f" option for xfs. ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
