----- Original Message ----- > From: "Stanislav Kholmanskikh" <stanislav.kholmansk...@oracle.com> > To: ltp-list@lists.sourceforge.net > Cc: "vasily isaenko" <vasily.isae...@oracle.com>, jstan...@redhat.com > Sent: Thursday, 22 August, 2013 9:41:47 AM > Subject: [PATCH V3 1/3] Added ALIGN, __ALIGN_MASK macroses > > Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmansk...@oracle.com>
The series looks good to me. I also ran it on small NUMA system, it worked fine. My only nit is this patch's subject, I believe plural of macro is macros :-). Reviewed-by: Jan Stancek <jstan...@redhat.com> > --- > include/test.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/test.h b/include/test.h > index d9eba31..a517ff9 100644 > --- a/include/test.h > +++ b/include/test.h > @@ -105,6 +105,12 @@ > #define MAP_PRIVATE_EXCEPT_UCLINUX MAP_PRIVATE > #endif > > +/* Round x to the next multiple of a. > + * a should be a power of 2. > + */ > +#define ALIGN(x, a) __ALIGN_MASK(x, (typeof(x))(a) - 1) > +#define __ALIGN_MASK(x, mask) (((x) + (mask)) & ~(mask)) > + > /* > * lib/forker.c > */ > -- > 1.7.1 > > ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
