Hi!
> +static void setup(void)
> +{
> +
> +     tst_require_root(NULL);
> +
> +     TEST_PAUSE;
> +
> +     tst_tmpdir();
> +
> +     SAFE_MKDIR(cleanup, mntpoint, 0755);
> +
> +     uid = 0;

One last nit. What is the point of setting uid to -1 first and then
changing it here to 0? Can't we just set it to 0 from the start?

> +     tst_mkfs(NULL, block_dev, "xfs", NULL);
> +
> +     if (mount(block_dev, mntpoint, "xfs", 0, "uquota") < 0)
> +             tst_brkm(TFAIL | TERRNO, NULL, "mount(2) fail");
> +
> +}

-- 
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to