On 09/16/2013 07:18 PM, [email protected] wrote: > Hi! >> Signed-off-by: Stanislav Kholmanskikh <[email protected]> >> --- >> testcases/kernel/syscalls/setfsgid/setfsgid01.c | 97 ++++-------- >> testcases/kernel/syscalls/setfsgid/setfsgid02.c | 95 ++++-------- >> testcases/kernel/syscalls/setfsgid/setfsgid03.c | 118 ++++++--------- >> testcases/kernel/syscalls/setfsuid/setfsuid01.c | 97 ++++-------- >> testcases/kernel/syscalls/setfsuid/setfsuid02.c | 96 ++++-------- >> testcases/kernel/syscalls/setfsuid/setfsuid03.c | 118 +++++---------- >> testcases/kernel/syscalls/setfsuid/setfsuid04.c | 183 >> +++++++++------------- >> testcases/kernel/syscalls/utils/compat_16.h | 13 ++ >> 8 files changed, 297 insertions(+), 520 deletions(-) > It's usually better to split the patches between cleanup and functional > changes but in this case the functional changes are simple enough... > > I've amended a few more fixes over this patches mostly another missing > void in function parameters and cosmetic changes. > > Note that for TEST_ERRNO you must use TTERRNO not TERRNO. > > Also notice that I've basically reverted the changes in > run_master_child() in setfsuid04. You must not use tst_* interface from > child, it's not designed to work this way and it may lead to unexpected > results. Thank you. I will take these points into account for the next testcases.
> > See attached patch (that is combined with your patch in the final one) > for details. > > Thanks! > ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
