On 10/23/2013 10:41 PM, [email protected] wrote: > Hi! >> Testcase cgroup sometimes fail although there is no bug found. >> Initialize the exit status to fix it. > The patch looks fine, but the description lacks rationale for the rmdir > change. > Thanks for review. Added more description.
From: Shuang Qiu<[email protected]> Testcase cgroup sometimes fail although there is no bug found. Initialize the exit status to fix it. Using "rmdir cgroup/" to clean up test_dir sometimes failed because there may be subdir not removed in cgroup/. Using "rmdir -p cgroup/*" instead. Signed-off-by: Shuang Qiu<[email protected]> --- .../controllers/cgroup/cgroup_regression_test.sh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh index f5e0b4b..356c000 100755 --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh @@ -28,6 +28,8 @@ export TCID="cgroup_regression_test" export TST_TOTAL=10 export TST_COUNT=1 +failed=0 + tst_kvercmp 2 6 29 if [ $? -eq 0 ]; then tst_brkm TCONF ignored "test must be run with kernel 2.6.29 or newer" @@ -523,7 +525,7 @@ for ((cur = 1; cur <= $TST_TOTAL; cur++)) test_$cur } -rmdir cgroup/ +rmdir -p cgroup/* exit $failed -- 1.7.7 ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
