Hi!
On 10/08/2013 04:54 PM, [email protected] wrote:
>
> On 10/03/2013 06:20 PM, [email protected] wrote:
>> Hi!
>>> User-space program determines block device major number using sysfs.
>>> User-space program loads/unloads kernel module.
>>> acpi_get_object_info external interface updated.
>>> ACPI bit register access function renamed.
>>> acpi_bus_get_power() changed to acpi_bus_update_power()
>>> Added block device queue to fix NULL dereference.
>>> Added acpi functions return status checks.
>>>
>>> Signed-off-by: Alexey Kodanev<[email protected]>
>>> ---
>>>   testcases/kernel/device-drivers/acpi/.gitignore    |    8 +
>>>   testcases/kernel/device-drivers/acpi/LtpAcpi.h     |    6 +-
>>>   testcases/kernel/device-drivers/acpi/LtpAcpiCmds.c |  439 
>>> +++++++++-----------
>>>   testcases/kernel/device-drivers/acpi/LtpAcpiMain.c |  169 +++++---
>>>   testcases/kernel/device-drivers/acpi/Makefile      |   43 +-
>>>   testcases/kernel/device-drivers/acpi/ltpacpi.sh    |   54 ---
>>>   6 files changed, 337 insertions(+), 382 deletions(-)
>>>   create mode 100644 testcases/kernel/device-drivers/acpi/.gitignore
>>>   delete mode 100755 testcases/kernel/device-drivers/acpi/ltpacpi.sh
>> I've looked at the code closely and the whole point of the device driver
>> is the ioclt() handler that is used to start the tests. I guess that we
>> can rewrite it to use sysfs interface too.
> OK. I'm also didn't find where in the test registered block device 
> could be used besides ioctl.
>> Otherwise the code looks like it tries to poke some of the ACPI
>> structures that are expected to be there by the ACPI specification and
>> try to register some handlers and LTP test device. The \_SB is root of
>> the system bus, then it tries to execute initialization on the system
>> bus which, if I'm reading the ACPI specification (free downloadable ~500
>> pages pdf) is noop if device is allready initialized.
>>
> yes, _INI method is noop and it's not changing _SB. I think it's 
> better to use it than e.g. _OFF.
So, what should we do with the method, leave it as is or change to 
something else?

------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to