Hi! > I've fixed the over 80 characters lines that my patches adds, > but there are other lines over 80 chars in the same file. > eg. > checkpatch.pl -f testcases/network/iproute/ip_tests.sh > .... > WARNING: line over 80 characters > #575: FILE: network/iproute/ip_tests.sh:575: > + ip maddr show | grep "66:66:00:00:00:66" > &>$LTPTMP/tst_ip.err \ > total: 0 errors, 22 warnings, 611 lines checked > > BTW, some test files combine spaces and tabs for indentation, and also have > over 80 chars lines. > eg. > testcases/network/multicast/* > testcases/network/nfs/* > > Maybe you could clean up them when you have time :)
There is a lot of legacy and messed up code and we are fixing it as fast as we can... But in order to get somewhere newly added code should be clean, otherwise we will never get to a clean codebase. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
