On Thursday 09 January 2014 08:09:19 [email protected] wrote:
> Hi!
> 
> > > +AC_DEFUN([LTP_CHECK_CLONE7ARGS],[
> > > +AH_TEMPLATE(HAVE_CLONE7ARGS,
> > > +[Define to 1 if clone() supports 7 arguments.])
> > > +AC_MSG_CHECKING([for CLONE7ARGS])
> > > +AC_TRY_LINK([#define _GNU_SOURCE
> > > +         #include <sched.h>
> > > +         #include <stdlib.h>],
> > > +         [
> > > +         #if !defined(__ia64__)
> > > +         clone(NULL, NULL, 0, NULL, NULL, NULL, NULL);
> > > +         #endif
> > > +         ],
> > > +         AC_DEFINE(HAVE_CLONE7ARGS) AC_MSG_RESULT(yes), 
> > > AC_MSG_RESULT(no))
> > > +])
> > 
> > you aren't really testing for "clone takes 7 args", you're testing for
> > "clone has varargs support".  rename the define (and use _ in its name),
> > and drop the ia64 check as it isn't needed.
> 
> I wouldn't call it varargs because there are only three more pointers to
> pass to clone() and the only reason it's defined as varargs is to be
> compatible with the previous clone definition...

fair enough.  the define still needs renaming like CLONE_ACCEPTS_7_ARGS.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to