Hi! On Thursday 13 February 2014 11:20 PM, [email protected] wrote: > Hi! > The whole patchset is send in one email and 'git am' applies only the > first patch. Can you please resend it correctly? > >> -Conditional inclusion of asm.h for kernel > 3.4 >> -The owner field of proc_dir_entry has been removed > When was this removed? If this is relatively recent change we should add > an ifdef around the initalization instead of removing it. Was removed in 2.6.30.
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=99b76233803beab302123d243eea9e41149804f3 will add a conditional #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 30) crasher_proc->owner = THIS_MODULE #endif >> Signed-off-by: Sweekar Pinto <[email protected]> >> --- >> testcases/kdump/lib/crasher/crasher.c | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/testcases/kdump/lib/crasher/crasher.c >> b/testcases/kdump/lib/crasher/crasher.c >> index bc192dc..2b01412 100644 >> --- a/testcases/kdump/lib/crasher/crasher.c >> +++ b/testcases/kdump/lib/crasher/crasher.c >> @@ -25,7 +25,10 @@ >> #include <linux/proc_fs.h> >> #include <linux/spinlock.h> >> #include <asm/uaccess.h> >> +#include <linux/version.h> >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 4, 0) >> #include <asm/system.h> >> +#endif > The inner include should look like: > > # include <asm/system.h> Not sure what you mean here? >> MODULE_LICENSE("GPL"); >> >> @@ -46,7 +49,7 @@ static int crasher_write(struct file *file, const char >> *buffer, >> unsigned long count, void *data) >> { >> char value, *a; >> - spinlock_t mylock = SPIN_LOCK_UNLOCKED; >> + DEFINE_SPINLOCK(mylock); >> >> /* grab the first byte the user gave us, ignore the rest */ >> if (copy_from_user(&value, buffer, 1)) >> @@ -94,7 +97,6 @@ int crasher_init(void) >> >> crasher_proc->read_proc = crasher_read; >> crasher_proc->write_proc = crasher_write; >> - crasher_proc->owner = THIS_MODULE; >> return 0; >> } >> >> -- >> 1.7.1 >> >> >> >From f58a6316dc168781daa76edf4d78a217e2af2628 Mon Sep 17 00:00:00 2001 >> From: Sweekar Pinto <[email protected]> >> Date: Wed, 22 Jan 2014 17:05:01 -0500 >> Subject: [PATCH 2/3] Fix passwordless ssh for network(ssh) dump test >> >> -Force ssh to use kdumps rsa key to run commands remotely >> >> Signed-off-by: Sweekar Pinto <[email protected]> >> --- >> testcases/kdump/runkdump.sh | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/testcases/kdump/runkdump.sh b/testcases/kdump/runkdump.sh >> index e2e681c..cd6ee1c 100755 >> --- a/testcases/kdump/runkdump.sh >> +++ b/testcases/kdump/runkdump.sh >> @@ -95,7 +95,7 @@ PrepareVerify () >> exit 1 >> fi >> >> - file=$(ssh "${SCP_PATH}" "ls -t ${COREDIR}/*/vmcore \ >> + file=$(ssh -i ~/.ssh/kdump_id_rsa "${SCP_PATH}" "ls -t >> ${COREDIR}/*/vmcore* \ >> 2>/dev/null | head -1") >> >> mkdir -p "${COREDIR}/${last}" >> @@ -103,7 +103,7 @@ PrepareVerify () >> if [ "${file}" ]; then >> # Not fatal error. >> set +e >> - scp "${SCP_PATH}:${file}" "${COREDIR}/${last}" >> + scp -i ~/.ssh/kdump_id_rsa "${SCP_PATH}:${file}" >> "${COREDIR}/${last}" >> set -e >> fi >> >> @@ -116,7 +116,7 @@ PrepareVerify () >> COREDIR=/mnt"${COREDIR}" >> fi >> >> - vmcore=$(ls -t "${COREDIR}"/*/vmcore 2>/dev/null | head -1) >> + vmcore=$(ls -t "${COREDIR}"/*/vmcore* 2>/dev/null | head -1) Some versions of kexec-tools append the date to the vmcore file. Hence the vmcore*. > This change is not explained in the commit message. > >> } >> >> VerifyTest () >> -- >> 1.7.1 >> >> >> >From 76ab06883327fdcdf038af5dd96a036e0b077818 Mon Sep 17 00:00:00 2001 >> From: Sweekar Pinto <[email protected]> >> Date: Wed, 22 Jan 2014 17:08:23 -0500 >> Subject: [PATCH 3/3] Change crashkernel param to 256M@128M >> >> -Change the crashkernel parm of x86 and default arch to 256M@128M as this is >> found to be the best fit > Can you elaborate further? The kernel documentation > (Documentation/kdump/kdump.txt) still says 64M@16M. We always get a "crashkernel reservation failed - memory is in use" with crashkernel=64M@16M on all of our test hardware. 256M@128M seems to be the best fit based on empirical data. Thanks, Sweekar > > Also format the commit message to 80 chars. > ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
