Hi! > >>> + rmmod rcutorture > /dev/null 2>&1 > >>> + if [ $? -ne 0 ]; then > >>> + tst_brkm TBROK NULL "failed to unload module" > >>> + exit 2 > >>> + fi > >>> + > >>> + # check module status in dmesg > >>> + result_str=`dmesg | tail -n 1` > >> This is quite fragile, if anything has added a line into dmesg while the > >> test was running it will fail. Better approach would be to save the > >> dmesg output into a file and grep it for the rcutorture resutl. > > And the best possible solution would be to add a more convinient > > interface to the module itself, but that would need to be comunicated > > with kernel upstream. > Messages quite informative and could be parsed easily. Do you mean > adding sysfs parameters to control the module?
Yes. I would rather see the test writing into a sysfs file and be blocked in the write till the test is finished which is more robust than the sleep it does currently. So for the time being I would go with the test as it is and try to start a discussion about making the module more friendly to automated testing on LKML. Does that sound reasonably? -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
