On 04/07/2014 10:12 PM, [email protected] wrote:
> Hi!
Hi!
>> diff --git a/testcases/network/rpc/basic_tests/rpc01/Makefile
>> b/testcases/network/rpc/basic_tests/rpc01/Makefile
>> index 732d816..68ea85e 100644
>> --- a/testcases/network/rpc/basic_tests/rpc01/Makefile
>> +++ b/testcases/network/rpc/basic_tests/rpc01/Makefile
>> @@ -28,7 +28,15 @@ include $(top_srcdir)/include/mk/env_pre.mk
>> CPPFLAGS += -Wno-error
>>
>> INSTALL_TARGETS := rpc01
>> -
>> SUBDIRS := datafiles
>>
>> +LIBSRCS := $(abs_srcdir)/librpc01.c
>> +INTERNAL_LIB := librpc01.a
>> +LDFLAGS += -L$(abs_srcdir)
>> +LDLIBS += -lrpc01
>> +
>> +MAKE_TARGETS := rpc1 rpc_server
>> +$(MAKE_TARGETS): $(INTERNAL_LIB)
>> +
>> include $(top_srcdir)/include/mk/generic_trunk_target.mk
>> +include $(top_srcdir)/include/mk/lib.mk
>
> There is a problem with this change. Including both trunk target and lib
> makes the install phase to install the MAKE_TARGETS both to
> /testcases/bin and /usr/lib{,64}/ (because each of them installs
> MAKE_TARGETS to INSTALL_DIR).
But why to /usr/lib{,64}?
I observe this:
[stas@kholmanskikh rpc01]$ sudo make install
mkdir -p "/opt/ltp/testcases/bin"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/rpc01"
"/opt/ltp/testcases/bin/rpc01"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/rpc1"
"/opt/ltp/testcases/bin/rpc1"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/rpc_server"
"/opt/ltp/testcases/bin/rpc_server"
mkdir -p "/opt/ltp/lib"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/rpc01"
"/opt/ltp/lib/rpc01"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/rpc1"
"/opt/ltp/lib/rpc1"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/rpc_server"
"/opt/ltp/lib/rpc_server"
make[1]: Entering directory
`/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/datafiles'
mkdir -p "/opt/ltp/testcases/data/rpc01"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/datafiles/file.1"
"/opt/ltp/testcases/data/rpc01/file.1"
install -m 00775
"/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/datafiles/file.2"
"/opt/ltp/testcases/data/rpc01/file.2"
make[1]: Leaving directory
`/home/stas/ltp/testcases/network/rpc/basic_tests/rpc01/datafiles'
So it's /opt/ltp/lib.
>
> Given that there may be other problems with this setup I would rather
> move the library to a subdirectory with it's own Makefile. What do you
> think?
>
I'm ok, and sending a patch to this.
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
