On Thu, 24 Apr 2014 11:06:05 +0200 <chru...@suse.cz> wrote: > > I couldn't find that function in include directory. Did I search in > > the wrong place? > > Ah, you are right, that one is missing, sorry. > > I will add it.
Ok. > > That would loose a lot of information useful for figuring out what > > the error is. For example, when called for translating command line > > options to integers, using SAFE_STRTOUL() will only say that "this > > string is not an integer" without giving any hint that we are > > talking about a command line option, and which option that is being > > parsed. > > Well it depends on the fact if the additional work is worth of the > clarity. > > Looked at the code it may be in this case. But at least remove the > base argument and just pass 10 to strtoull() instead. Keep things > simple :) Trying to be a transparent wrapper was my definition of simplicity, but having a simpler function interface is certainly another... Both works for me, so I can change it. > > This is because assert_exit_status() sometimes checks result of > > executed commands, and in those cases this function gets a command > > line rather than PID. > > I've greped the source code for assert_exit_status and it's called > from pid_wait() and cleanup() in both cases the first argument is > result of: > > snprintf(buf, sizeof(buf), "Pid %lu", pid) > > Do I miss something? Yep, you greped the wrong source code. I've rewritten some code due to other review remarks and when viewing the code after those changes I came to the above conclusion. I'm a bit in the middle of changes so I forgot to mention this somewhat important aspect... Regards Mats Liljegren ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
