Thanks for your suggestion. I will send a new version v5. Regards, Xing Gu
δΊ 05/07/2014 01:26 AM, chru...@suse.cz ει: > Hi! >> +/* lib/tst_path_has_mnt_flags.c >> + * >> + * Check whether a path is on a filesystem that is mounted with >> + * specified flags. >> + * @path: path to file >> + * @flags: mount flags > > You should describe that flags is NULL terminated array here. > > And add a note about the return value (which is number of flags matched). > >> + */ >> +int tst_path_has_mnt_flags(const char *path, const char *flags[]); > > Looking at the function interface, we may add the clenanup callback > parameter and do tst_brkm(TBROK, ) instead of the return -1. What do you > think? > >> #ifdef TST_USE_COMPAT16_SYSCALL ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
