On Mon, 12 May 2014 17:34:05 +0200
<[email protected]> wrote:

> Hi!
> > > I've added missing return stream; here and pushed both patches,
> > > thanks.
> > 
> > Whoa, did I really miss that? Wondering how my test could have
> > run... Must have used the wrong version of the code when testing or
> > something.
> 
> I've seen cases where such code was running fine because the register
> used to return function value was the same that was allocated for the
> temporary variable...

I thought about that alternative but discarded it as too unlikely, but
apparently, I shouldn't have been so quick about it apparently...

> > Now you know why I really liked forcing people into using
> > -Werror ;-) Could it be a good idea to actually use -Werror by
> > default, and having a "production" flag for those who don't want
> > it? Just to ensure that lazy people are those being best looked
> > after...
> 
> I would be for reversing the logic, i.e. adding developer flag that
> enables -Werror. Unfortunatelly LTP has tons of legacy code that
> produces megatons of warnings and fixing all of these would be a big
> effort.
> 

Hmm, but a compromise could be this:

Let's say we have a "production flag" which then each module could make
their mind up whether it should have any effect or not. If it should
have an effect, then the effect should be to disable -Werror.

This way, you can fix warnings on one module at a time, no big bang
change. When a module is fixed, you change it to use -Werror unless
this "production flag" is used.

Would that be a way forward?

Regards
Mats Liljegren

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to