Hi! > > > On Fri 11 Apr 2014 13:26:59 Alexey Kodanev wrote: > > > > +backup_cflags="$CFLAGS" > > > > +CFLAGS="-Wold-style-definition" > > > > > > this isn't really safe. the CFLAGS might have critical settings in there > > > that > > > impact linking. why not just append ? > > > > We can also change the AC_LINK_IFELSE() to AC_COMPILE_IFELSE(). > > > > Given this is not critical (the worst case is that old style warnings > > are not enabled) this could wait after the release. > > The freeze has been lifted up, feel free to push fix if you want :)
I've just pushed a fix that appends the CFLAGS instead of replacing them. -- Cyril Hrubis chru...@suse.cz ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
