Hi, On 05/20/2014 08:24 PM, chru...@suse.cz wrote: > >> Agree, thanks. >> For xfs, the number of links is unlimited. >> For ext2/3, the number of links is 32000. >> For ext4, it depends some options. >> >> So for xfs, I will skip EMLINK test for it. >> For other files ystems, I will try to create as many as files, until the >> EMLINK Is hit. >> if EMLINK is not hit, there must be some other errors, such as ENOSPC, for >> this >> case, the EMLINK test should also be skipped. > What about we create tst_get_max_links(const char *path) library > function that would either return the actual limit or -1 if unlimited? > > Because this would be needed in more than one testcase, at least in the > link() and linkat() ones. OK, but normal file's hard link count is sometimes different from directory's. When we test EMLINK for link(), we want to know the normal file's max hard links, and when testing EMLINK for rename(). we want to know the directory's max link counts.
And for ext2/3/4 file system, they have the same magic number, so we couldn't get the file system type by using statfs(), so I think these interfaces would be better like below: int tst_fs_get_max_hardlinks(const char *filesystem); int tst_fs_max_subdirs_per_dir(const char *filesystem); Here is the patch: http://sourceforge.net/p/ltp/mailman/message/32368238/ Would you ok with these changes, thanks. Regards, Xiaoguang Wang > ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
