Sorry, version v3 is the latest version. Please ignore the version v2.
Regards,
Xing Gu
于 06/17/2014 03:08 PM, gux.fnst 写道:
>
>
> 于 05/20/2014 11:42 PM, chru...@suse.cz 写道:
>> Hi!
>>> +#define TESTDIR "testdir"
>>> +#define NEW_TESTDIR "newtestdir"
>>> +#define TESTFILE "testfile"
>>> +#define NEW_TESTFILE "newtestfile"
>>> +#define TESTFILE2 "testdir/testfile"
>>> +#define NEW_TESTFILE2 "newtestdir/newtestfile"
>>> +#define TESTFILE3 "/tmp/testfile3"
>>> +#define NEW_TESTFILE3 "/tmp/newtestfile3"
>>
>> The test must not create files outside of the test tmpdir. Have a look
>> at mkdriat01.c, readlinkat01.c or any *at01.c that I've fixed recently.
>>
>> You need to construct the absolute path from output of tst_get_tmpdir().
>
> Got it.
>
>>
>>> +static void setup(void);
>>> +static void cleanup(void);
>>> +static void test_success1(void);
>>> +static void test_success2(void);
>>> +static void test_success3(void);
>>> +static void test_enotdir(void);
>>> +static void test_ebadf(void);
>>> +static void check_and_print(int expected_errno);
>>> +
>>> +static void (*testfunc[])(void) = { test_success1, test_success2,
>>> + test_success3, test_enotdir, test_ebadf };
>>
>> I think that the data driven approach (having one structure with all
>> parameters and single test function) is a bit easier to read, but that
>> is not a big problem. Have a look at mkdirat01.c.
>>
> Got it.
>
> Thanks for your suggestion. I will send a new version v2.
>
> Regards,
> Xing Gu
>
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
