Hi! > > I like TBROK here, because if you forget the required parameter, > > testcase will end with non-zero exit code, which should be > > easily visible for any test harness, while with TCONF the > > problem can go unnoticed (with retcode == 0).
Yes, I think that this should be TCONF rather than TBROK because the conditions for the test weren't met. However I understand your concerns as well and this is a one of the reasons I was thinking of changing the library to propagate the TCONF to the test exit value as well. Ideally we should fix the GitHub issue #11 which would change the code so that we don't have to do the check in the first place. (https://github.com/linux-test-project/ltp/issues/11) I was thinking of adding a function that would either get the LTP_DEV env variable or create a loop0 device if LTP_DEV is not set and will format it with LTP_DEV_FS_TYPE or a default passed value and it's counter part that does the cleanup. -- Cyril Hrubis chru...@suse.cz ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
