On Fri, 2014-06-20 at 05:35 -0400, Jan Stancek wrote:
> > int TST_TOTAL = 1;
> >
> > -int exp_enos[] = { 0, 0 };
> > +static int exp_enos[] = { 0, 0 };
>
> This looks like it can be removed along with TEST_EXP_ENOS().
>
Got it.
> > +
> > +static int fork_pid, ret_code;
>
> These can be local variables.
>
Yeah, these should be local variables.
> > +
> > + TEST(wait(&ret_code));
>
> I know this wasn't in original code, but I suggest to add some check for
> ret_code too (WIFEXITED() && WEXITSTATUS() == 1).
>
OK. I will add them.
And thanks for your review.
Best regards,
Zeng
> Regards,
> Jan
>
> >
> > + if (TEST_RETURN == -1) {
> > + TEST_ERROR_LOG(TEST_ERRNO);
> > + tst_resm(TFAIL | TTERRNO, "wait(1) Failed");
> > + } else {
> > + tst_resm(TPASS, "wait(&ret_code) returned %ld", TEST_RETURN);
> > + }
> > }
> >
> > -/***************************************************************
> > - * cleanup() - performs all ONE TIME cleanup for this test at
> > - * completion or premature exit.
> > - ***************************************************************/
> > -void cleanup(void)
> > +static void cleanup(void)
> > {
> > - /*
> > - * print timing stats if that option was specified.
> > - * print errno log if that option was specified.
> > - */
> > TEST_CLEANUP;
> > -
> > }
> > --
> > 1.9.3
> >
> >
> >
> >
> > ------------------------------------------------------------------------------
> > HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> > Find What Matters Most in Your Big Data with HPCC Systems
> > Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> > Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> > http://p.sf.net/sfu/hpccsystems
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> >
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
