Hi! > >> ret=1 > >> > >> + temp_tmpdir=$TMPDIR > >> + export TMPDIR=mnt_point > >> for ((i = 1; i <= 3; i++)) > >> { > >> if ! command -v fallocate0${i} > /dev/null 2>&1; then > >> @@ -63,6 +65,7 @@ ext4_test_persist_prealloc() > >> return > >> fi > >> } > >> + TMPDIR=$temp_tmpdir > > > > > > Can't we just do: > > > > TMPDIR=mnt_point; fallocate0${i} > > > > instead? > > Yeah, we can do it, but this will make TMPDIR still be "mnt_point" after the > fallocate tests.
That is the point of it. As it is you are saving and restoring the TMPDIR before and after the loop so redefining it only for the part that matters looks cleaner to me or did I overlooked something? -- Cyril Hrubis chru...@suse.cz ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list