On 06/25/2014 04:14 PM, chru...@suse.cz wrote: > Hi! >> 1. We remove get_max_pids(), because it's used only in one place >> (get_free_pids()) >> and can be subsituted with >> SAFE_FILE_SCANF(cleanup_fn, PID_MAX_PATH, "%d", &pid); >> >> 2. We rename get_free_pids() to tst_get_free_pids() for consistency. And >> changing a bit its >> declaration to use SAFE_FILE_SCANF(). >> >> 3. system_specific_process_info.h is used only in one place - msgctl11. >> I think it's not a problem if I move its content to test.h. For >> consistency. >> >> 4. And add tst_get_unused_pid() to system_specific_process_info.c. To not >> create a new source file. And this funcion looks logically coupled with >> tst_get_free_pids(). >> >> I'm going to present pp. 1-3 in one patch, and p. 4 - in a separate patch. >> >> What do you think about the general idea? > > Sounds good to me. > > Perhaps we should also rename the system_specific_process_info.c to > something shorter and more to the point. Maybe just process_info.c or > pidutils.c or something similar. > Maybe tst_pid.c ? :)
------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
