Hi!
> +static struct test_case_t {
> + int *fd;
> + const struct iovec *iov;
> + unsigned long nr_segs;
> + int exp_errno;
> +} test_cases[] = {
> + { ¬validfd, &ivc, VMSPLICE_LEN, EBADF },
> + { &filefd, &ivc, VMSPLICE_LEN, EBADF },
^
I've changed these two to 1 because it
should denote the size of the array containing
the iovec structures which, for single iovec
is 1
> + { &pipes[1], &ivc, IOV_MAX + 1, EINVAL },
> +};
...
> +static void setup(void)
> +{
> + int i;
> +
> + if ((tst_kvercmp(2, 6, 17)) < 0) {
> + tst_brkm(TCONF, cleanup, "This test can only run on "
> + "kernels that are 2.6.17 or higher");
> + }
> +
> + tst_sig(NOFORK, DEF_HANDLER, cleanup);
> +
> + TEST_PAUSE;
> +
> + tst_tmpdir();
> +
> + if (tst_fs_type(cleanup, ".") == TST_NFS_MAGIC) {
> + tst_brkm(TCONF, cleanup, "Cannot do splice() "
> + "on a file located on an NFS filesystem");
> + }
> +
> + for (i = 0; i < TEST_BLOCK_SIZE; i++)
> + buffer[i] = i & 0xff;
And I've removed this initialization which is not needed for
anything (the buffer is not used at all).
> + filefd = SAFE_OPEN(cleanup, TESTFILE,
> + O_WRONLY | O_CREAT, 0644);
> +
> + SAFE_PIPE(cleanup, pipes);
> +
> + ivc.iov_base = buffer;
> + ivc.iov_len = TEST_BLOCK_SIZE;
> +}
> +
And pushed, thanks.
--
Cyril Hrubis
chru...@suse.cz
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
