Hi, all! I'm also finding a fair number of tests (hung runs of run_cpuctl_test.sh I'm looking at you) blindly use hard-coded path $LTPROOT/output/. Its existence is not fully enforced by runltp, though it tries half-heartedly.
Suggested first-hack fix: install the directory inside runltp's setup().
Provided in attached DIFF as well, since (sadly) something in my company's
email infrastructure mangles whitespace.
==== 8< ==== 8< ====
--- runltp.orig 2014-07-18 14:56:08.918779305 +0000
+++ runltp 2014-07-18 15:16:34.352791208 +0000
@@ -96,6 +96,9 @@
echo "INFO: Follow directions in INSTALL!"
exit 1
}
+
+ # TODO refactor out tests hard-coding this path
+ install -m 0755 -d "$LTPROOT/output"
}
==== >8 ==== >8 ====
Longer-term refactoring might be to clean up runltp's handling of relative
paths in options, and to replace these hard-coded paths by a guarded
environment variable in some sourced shell-file.
Thanks!
Joseph
Joseph Beckenbach, senior QA engineer : Automation
x97166
M 678-602-3192
DIFF
Description: DIFF
------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds
_______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
