----- Original Message ----- > From: chru...@suse.cz > To: "Jan Stancek" <jstan...@redhat.com> > Cc: "Matus Marhefka" <mmarh...@redhat.com>, ltp-list@lists.sourceforge.net, > me...@suse.de > Sent: Monday, 28 July, 2014 4:34:29 PM > Subject: Re: [LTP] [PATCH v3] containers: added pidns/pidns03.c > > Hi! > > > > looks good to me, with small note to make umount also in readlink() > > > > error > > > > path. > > > > If there'll be no other objections from Cyril, I can add that during > > > > commit > > > > (no need to resubmit). > > > > > > The latest version looks good to me as well. > > > > > > Maybe we can add a comment that would explain that /proc/self points to > > > directory named with the process pid so that it's clear why readlink > > > returns the process pid there. > > > > Pushed with extra comment about proc/self symlink. > > Looking at the commit we miss runtest record. > > Even more the testcases are currently executed by the runpidnstest.sh. > > Can we get that converted to a runtest file and have the pidns03 added?
We can, but we will probably need to add equivalent of "check_pidns_enabled" to setup() in every testcase. I can look into that. Regards, Jan > > -- > Cyril Hrubis > chru...@suse.cz > ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
