----- Original Message -----
> From: "Jan Stancek" <jstan...@redhat.com>
> To: chru...@suse.cz
> Cc: "ltp-list" <ltp-l...@lists.sf.net>
> Sent: Wednesday, 20 August, 2014 5:47:46 PM
> Subject: Re: [LTP] open12 failing on i386 with EOVERFLOW
> 
> 
> 
> 
> 
> ----- Original Message -----
> > From: chru...@suse.cz
> > To: "Jan Stancek" <jstan...@redhat.com>
> > Cc: "ltp-list" <ltp-l...@lists.sf.net>
> > Sent: Wednesday, 20 August, 2014 4:19:52 PM
> > Subject: Re: [LTP] open12 failing on i386 with EOVERFLOW
> > 
> > Hi!
> > > # env PATH=`pwd`:$PATH ./open12
> > > open12      1  TFAIL  :  open12.c:104: test O_APPEND for open failed
> > > open12      2  TCONF  :  open12.c:123: test O_NOATIME flag for open needs
> > > filesystems which is mounted without noatime and relatime
> > > open12      3  TPASS  :  test O_CLOEXEC for open success
> > > open12      4  TPASS  :  test O_LARGEFILE for open success
> > > open12      0  TWARN  :  tst_tmpdir.c:206: tst_rmdir:
> > > rmobj(/tmp/opexIqjV3)
> > > failed: lstat(/tmp/opexIqjV3/large_file) failed; errno=75: Value too
> > > large
> > > for defined data type
> > > 
> > > Since it's linked from library, adding -D_FILE_OFFSET_BITS=64 to this
> > > testcase has
> > > no effect.
> > > 
> > > One simple way to fix it would be to unlink it in test, so that
> > > rmobj.c doesn't hit it.
> > 
> > That is simple enough but I'm a bit reluctant to add the fix to each
> > test that will test O_LARGEFILE.
> > 
> > Given that the only purpose of lstat() in rmobj() is to figure out if
> > given path is a file or directory, we can try to work around this by
> > trying to opendir() the path first and treat it like a file when we get
> > ENOTDIR. What do you think?
> 
> I like the idea. I can try it tomorrow, unless you have patch ready.

I hit some issues with opendir() because it tries to follow symlinks,
so in case of bad symlink I was getting ENOENT, in some testcases ELOOP.

I posted version using plain open(O_DIRECTORY | O_NOFOLLOW,..), if you
want to comment on such approach. Initial results from x86 and ppc64 looked
good, so I'll run it through some more testing.

Regards,
Jan

> 
> Regards,
> Jan
> 
> > 
> > --
> > Cyril Hrubis
> > chru...@suse.cz
> > 
> 
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to