Hi!
> +# SETUP
> +tst_require_root
> +which ip &>/dev/null || tst_brkm TCONF "ip utility is required for this test"
> +which ifconfig &>/dev/null ||
> +     tst_brkm TCONF "ifconfig utility is required for this test"

We have tst_check_cmds in test.sh exactly for this purpose. And looking
at the code below we only need ifconfig for test case #1, there is no
need to skip the whole test if it's no present.

The rest of the code looks good.

-- 
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to