----- Original Message -----
> From: "Andrey Vagin" <ava...@openvz.org>
> To: ltp-list@lists.sourceforge.net
> Cc: "Andrey Vagin" <ava...@openvz.org>
> Sent: Wednesday, 10 September, 2014 12:00:54 PM
> Subject: [LTP] [PATCH 2/2] inotify: print event->name accoding with
> event->len
>
> Signed-off-by: Andrey Vagin <ava...@openvz.org>
> ---
> testcases/kernel/syscalls/inotify/inotify02.c | 8 ++++----
> testcases/kernel/syscalls/inotify/inotify04.c | 15 ++++++++-------
> 2 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/inotify/inotify02.c
> b/testcases/kernel/syscalls/inotify/inotify02.c
> index f4f93fc..69bc0ff 100644
> --- a/testcases/kernel/syscalls/inotify/inotify02.c
> +++ b/testcases/kernel/syscalls/inotify/inotify02.c
> @@ -216,8 +216,8 @@ int main(int ac, char **av)
> tst_resm(TFAIL,
> "get unnecessary event: "
> "wd=%d mask=%x cookie=%u len=%u"
> - "name=\"%s\"", event->wd, event->mask,
> - event->cookie, event->len,
> + "name=\"%.*s\"", event->wd,
> event->mask,
> + event->cookie, event->len, event->len,
> event->name);
>
> } else if ((event_set[test_num].mask == event->mask)
> @@ -244,10 +244,10 @@ int main(int ac, char **av)
> if (!fail) {
> tst_resm(TPASS,
> "get event: wd=%d mask=%x "
> - "cookie=%u len=%u name=\"%s\"",
> + "cookie=%u len=%u
> name=\"%.*s\"",
> event->wd, event->mask,
> event->cookie, event->len,
> - event->name);
> + event->len, event->name);
> } else {
> tst_resm(TFAIL,
> "get event: wd=%d mask=%x "
> diff --git a/testcases/kernel/syscalls/inotify/inotify04.c
> b/testcases/kernel/syscalls/inotify/inotify04.c
> index 7c3fdef..e8cdbab 100644
> --- a/testcases/kernel/syscalls/inotify/inotify04.c
> +++ b/testcases/kernel/syscalls/inotify/inotify04.c
> @@ -223,8 +223,8 @@ int main(int argc, char **argv)
> tst_resm(TFAIL,
> "got unnecessary event: "
> "wd=%d mask=%x cookie=%u len=%u "
> - "name=\"%s\"", event->wd, event->mask,
> - event->cookie, event->len, event->name);
> + "name=\"%.*s\"", event->wd, event->mask,
> + event->cookie, event->len, event->len,
> event->name);
>
> } else if ((event_set[test_num].mask == event->mask)
> &&
> @@ -233,18 +233,19 @@ int main(int argc, char **argv)
> event->len))) {
> tst_resm(TPASS,
> "got event: wd=%d mask=%x "
> - "cookie=%u len=%u name=\"%s\"",
> + "cookie=%u len=%u name=\"%.*s\"",
> event->wd, event->mask, event->cookie,
> - event->len, event->name);
> + event->len, event->len, event->name);
>
> } else {
> tst_resm(TFAIL, "got event: wd=%d mask=%x "
> "(expected %x) cookie=%u len=%u "
> - "name=\"%s\" (expected \"%s\") %d",
> + "name=\"%.*s\" (expected \"%.*s\") %d",
> event->wd, event->mask,
> event_set[test_num].mask,
> - event->cookie, event->len, event->name,
> - event_set[test_num].name,
> + event->cookie, event->len,
> + event->len, event->name,
> + event_set[test_num].len,
> event_set[test_num].name,
Hi,
event_set[test_num].len doesn't seem to be initialized anywhere, so in unlikely
case this fails (and len is 0) you get:
TFAIL got event: wd=2 mask=400 (expected 400) cookie=0 len=0 name=""
(expected "") 114
instead of:
TFAIL got event: wd=2 mask=400 (expected 400) cookie=0 len=0 name=""
(expected "test_file") 114
I'd suggest to keep last "%s" as it is now. It's used for
"event_set[test_num].name",
which is always initialized. Then event_set's "len" field wouldn't be used for
anything,
and could be removed from both inotify02.c and inotify04.c.
Regards,
Jan
> strcmp(event_set[test_num].name, event->name));
> }
> test_num++;
> --
> 1.9.3
>
>
> ------------------------------------------------------------------------------
> Want excitement?
> Manually upgrade your production database.
> When you want reliability, choose Perforce
> Perforce version control. Predictably reliable.
> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
