Hi, Jan, all!

Apologies for non-standard reply format:  I'm forced to use a brain-dead 
WYSIWYG GUI for text processing
fronting a brain-dead email processor which often fails to honor newlines in 
original text. :-b

In 
b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_testset.sh
in @@ -299,7 +299,18 @@ and @@ -316,7 +327,18 @@ you use
====
+       grep "TCONF" "$TEST_OUTPUT"
+       if [ $? -eq 0 ]; then
+               return 0
+       fi
+
+       if [ $ret -ne 0 ]; then
+               return 1
+       fi
====

perhaps express this more idiomatically:
====
+       grep "TCONF" "$TEST_OUTPUT" && return 0
+       [ $ret -ne 0 ] && return 1
====

This appears to be elsewhere in test15() and test16(), so I presume it's 
throughout the file,
and thus worthy of a separate refactoring patch if anyone chooses to perform 
this.

Thanks!

Joseph
Joseph Beckenbach, senior QA engineer : Automation  -- +1-470-299-7166
Lancope, Inc. -- makers of StealthWatch


------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to